• 0 Posts
  • 15 Comments
Joined 2 years ago
cake
Cake day: June 16th, 2023

help-circle






  • “oh, i don’t know what this native english speaker is saying, i guess english is still a skill i’m working on”

    I’m no native English speaker as well, and that’s how I often think as well. In my mother tongue I know so many words, their meaning and their sound. In English, however, I’m still learning new words now and then, and it opens my world to the language every time. This is true for dialects as well.

    Learning a new language is quite hard in the beginning, but it’s so satisfying and world opening when you start to actually use a new language.

    edit Ohh, and sorry for my bad English ;)





  • It’s not just random, it simply does not even work. Because they set this:

    +/*Preferred Core featue is supported*/
    +static bool prefcore = true;
    

    And later in the code they do the if condition wrong:

    +	if (prefcore)
    +		WRITE_ONCE(cpudata->highest_perf, AMD_PSTATE_PREFCORE_THRESHOLD);
    +	else
    +		WRITE_ONCE(cpudata->highest_perf, AMD_CPPC_HIGHEST_PERF(cap1));
    

    if should look like this:

    +	if (prefcore)
    +		WRITE_ONCE(cpudata->highest_perf, AMD_CPPC_HIGHEST_PERF(cap1));
    +	else
    +		WRITE_ONCE(cpudata->highest_perf, AMD_PSTATE_PREFCORE_THRESHOLD);
    

    There is probably even more wrong, looking at the code quality, but this at least makes the preferred core work.




  • but I have used the video encode hardware on AMD cards via VAAPI and it was competent and much faster than x264/x265 on the CPU.

    Yes, it’s faster than the CPU, which is no surprise, but the quality is incredibly worse than NVENC. I switched to AMD earlier this year and I knew that the AMD video encoder wouldn’t match NVENC, but the difference is much bigger than I’ve ever thought.