Move fast and break things.
Merge vulnerabilities.
Double the work.
Merge code without tests.
Anything, but don’t let code become stale.

  • jjjalljs@ttrpg.network
    link
    fedilink
    arrow-up
    2
    ·
    1 year ago

    Ah. Yeah those kind of nitpicks are annoying. We try to specify when comments are blocking or non blocking on reviews.

    But I definitely block a lot of reviews over no tests, bad tests, no error handling, failed linting. And the occasional “this doesn’t do what the ticket asked for”